Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in JSON serialization error message. #70

Merged
merged 1 commit into from
Jan 20, 2019

Conversation

alex-ozdemir
Copy link
Contributor

I stumbled upon a small typo while reading the source.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@davidbarsky
Copy link
Contributor

Thanks for opening this PR! This change looks good to me—I'll try to see why the build is failing on nightly, while it's succeeding on stable.

@alex-ozdemir
Copy link
Contributor Author

This failure is actually unrelated to this PR.

A few days ago the doc-dude, Giullaume landed this PR, which made the missing_docs warning stop ignoring macro_rules macro definitions. Since y'all have #[deny(warnings)] on in the lambda-runtime crate, and this macro is missing documentation, this caused the build to fail on nightly.

I've added documentation for that macro in this PR.

@davidbarsky
Copy link
Contributor

This failure is actually unrelated to this PR.

Yep, you're right! I meant to say “investigate what happened in rustc”, but thanks for doing that research for me!

@davidbarsky
Copy link
Contributor

Once #71 is merged, I'll restart this build—I don't think that a rebase is necessary. Thanks for your help!

@davidbarsky davidbarsky merged commit 7d66db7 into awslabs:master Jan 20, 2019
@davidbarsky
Copy link
Contributor

Thanks! Just merged these changes. Also, I'm sorry about the delay! I'll ask the administrators of the awslabs organization if email notifications can be turned on.

@alex-ozdemir alex-ozdemir deleted the error-msg-type branch January 20, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants