runCommand feature + integration tests #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do verification and jobdocument validation
…r command contains space
…to string, added a sample doc for runCommand
xlcheng1
requested review from
HarshGandhi-AWS,
shangabl,
BolongZhang-AWS,
marcoemorais-aws and
RogerZhongAWS
RogerZhongAWS
approved these changes
Dec 13, 2022
shangabl
approved these changes
Dec 14, 2022
RogerZhongAWS
pushed a commit
that referenced
this pull request
Jan 3, 2023
* runCommand test * Added code branch to execute commands without user and sudo, fixed sudo verification and jobdocument validation * refactoring * updated input struct, added unit tests * Addressed comments from previous revision, added another unit test for command contains space * Addressed comments * Added SplitByComma for command * updated README for runCommand, fixed SIGFAULT when command is empty * fixed a typo * added README part asking user not to provide sudo inside command field * addressed comments, changed type of command from console and job doc to string, added a sample doc for runCommand * moved string manipulation functions to StringUtils, added unit tests * Added trimming spaces for command field * fixed a typo in sample job doc * fixed wrong command type in README * added integration tests for runCmd * fixed typo in job doc for integration test * testing * resolved old job doc causing seg fault * removed debug cout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
Please describe what changes are included in this pull request.
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.