-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lockfile handler #332
Conversation
88325ef
to
aae1bce
Compare
Can you add an integration test for this? Or at least remove the part of the integration tests entry-point.sh script that create the /run/lock directory and make sure it still works. We may want to add a test though where we try to run DC again and verify it fails. |
ddd6724
to
da926dd
Compare
integration-tests/entry-point.sh
Outdated
./aws-iot-device-client | ||
retVal=$? | ||
if [ $retVal -ne 1 ]; then | ||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add more comments walking through this... This is actually an integration test but it doesn't say that.
Lets explicitly call this out as as a test, explain each step.
And can you add some stdout for the failure case? If our integration tests just stop running because of a lock file issue we want to know why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the test to no longer check for the return code of device client (in the case where device client keeps running and does not exit) but instead checks for the return code of pkill after we kill the dummy process first. This value will be 1 if there is no such process named 'aws-iot-device-client'
note: add exception handler for stoi call |
d6a6ea7
to
393c31d
Compare
332efa5
to
29b0a70
Compare
* fixes bug of device client not starting when filesystem requirements are not met
Motivation
Modifications
Change summary
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.