HTTP proxy support #290
Merged
HTTP proxy support #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -185,7 +185,7 @@ endif () | |||
| ############################################### | |||
| ## Build the AWS IoT Device Client Executable # | |||
| ############################################### | |||
| add_executable(${DC_PROJECT_NAME} ${DC_SRC}) | |||
| add_executable(${DC_PROJECT_NAME} ${DC_SRC} source/util/ProxyUtils.cpp source/util/ProxyUtils.h) | |||
There was a problem hiding this comment.
not sure how this change made it back, but don't forget to remove the changes to the top-level CMakeLists and test/CMakeLists
There was a problem hiding this comment.
Good catch! addressed
BolongZhang-AWS
force-pushed
the
http_proxy
branch
from
1628366
to
853104a
Compare
RogerZhongAWS
previously approved these changes
Jul 15, 2022
BolongZhang-AWS
requested review from
marcoemorais-aws
and removed request for
marcoemorais-aws
shangabl
approved these changes
Jul 18, 2022
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 29, 2023
* HTTP proxy support
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 30, 2023
* HTTP proxy support # Conflicts: # docs/PERMISSIONS.md # source/config/Config.cpp # source/config/Config.h # test/config/TestConfig.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous approved staging repo PR: https://github.com/awslabs/private-aws-iot-device-client-staging/pull/4
Motivation
Adding HTTP proxy support with basic username and password authentication scheme.
~/.aws-iot-device-client/http-proxy.conf--http-proxy-configfor overriding default config setting in path~/.aws-iot-device-client/http-proxy.confModifications
PlainConfig::HttpProxyConfigwith HTTP proxy related parametersPlainConfigto support loading information from CLI, json config then validate.Config::ParseConfigFileto validate file path and permissions for HTTP proxy config fileProxyUtilsfor HTTP proxy related validation function utilitiesChange summary
Please describe what changes are included in this pull request.
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Unit Test:
ProxyUtils/config/ConfigManual testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.