Fixes CLI parsing bug #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI Arg parsing errors were returning 0, this fixes that by separating the help/version arg checks to a different method
RogerZhongAWS
approved these changes
Jul 7, 2022
| @@ -1985,74 +1985,87 @@ constexpr char Config::CLI_CONFIG_FILE[]; | |||
| constexpr char Config::DEFAULT_FLEET_PROVISIONING_RUNTIME_CONFIG_FILE[]; | |||
| constexpr char Config::DEFAULT_SAMPLE_SHADOW_OUTPUT_DIR[]; | |||
|
|
|||
| bool Config::CheckTerminalArgs(int argc, char **argv) | |||
| { | |||
| for (int i = 1; i < argc; i++) | |||
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 29, 2023
* Fixes CLI parsing bug
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 30, 2023
* Fixes CLI parsing bug # Conflicts: # source/config/Config.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CLI Arg parsing errors were returning 0, this fixes that by separating the help/version arg checks to a different method
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.