Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version CLI option #280

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Add --version CLI option #280

merged 6 commits into from
Jun 8, 2022

Conversation

HarshGandhi-AWS
Copy link
Contributor

Motivation

  • Please give a brief description for the background of this change.
    Add --version CLI option to print DC binary version

Modifications

Change summary

Please describe what changes are included in this pull request.

  • Added logic to print current DC binary version
  • Updated version of DC.

Revision diff summary

If there is more than one revision, please explain what has been changed since the last revision.

Testing

Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.

  • CI test run result:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

RogerZhongAWS
RogerZhongAWS previously approved these changes Jun 2, 2022
shangabl
shangabl previously approved these changes Jun 6, 2022
@@ -1 +1 @@
v1.6.0-31d162e*v1.6*1*6*0*0*31d162e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be required since the version is auto-incremented by CMakeLists.txt.versioning

@HarshGandhi-AWS HarshGandhi-AWS merged commit fc64b02 into main Jun 8, 2022
@HarshGandhi-AWS HarshGandhi-AWS deleted the versionFix branch June 8, 2022 17:22
joenghoyin pushed a commit to eguanatech/aws-iot-device-client-deprecated that referenced this pull request Aug 29, 2023
* Add --version CLI option

* updated DC version

* undone the version update in file .version

Co-authored-by: marco morais <[email protected]>
joenghoyin pushed a commit to eguanatech/aws-iot-device-client-deprecated that referenced this pull request Aug 29, 2023
* Add --version CLI option

* updated DC version

* undone the version update in file .version

Co-authored-by: marco morais <[email protected]>
# Conflicts:
#	source/config/Config.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants