-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --version CLI option #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerZhongAWS
previously approved these changes
Jun 2, 2022
shangabl
previously approved these changes
Jun 6, 2022
marcoemorais-aws
previously approved these changes
Jun 6, 2022
@@ -1 +1 @@ | |||
v1.6.0-31d162e*v1.6*1*6*0*0*31d162e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required since the version is auto-incremented by CMakeLists.txt.versioning
HarshGandhi-AWS
dismissed stale reviews from marcoemorais-aws, shangabl, and RogerZhongAWS
via
June 7, 2022 19:00
7e92b67
HarshGandhi-AWS
requested review from
shangabl,
RogerZhongAWS and
marcoemorais-aws
June 7, 2022 19:01
shangabl
approved these changes
Jun 7, 2022
RogerZhongAWS
approved these changes
Jun 7, 2022
marcoemorais-aws
approved these changes
Jun 7, 2022
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 29, 2023
* Add --version CLI option * updated DC version * undone the version update in file .version Co-authored-by: marco morais <[email protected]>
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 29, 2023
* Add --version CLI option * updated DC version * undone the version update in file .version Co-authored-by: marco morais <[email protected]> # Conflicts: # source/config/Config.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add --version CLI option to print DC binary version
Modifications
Change summary
Please describe what changes are included in this pull request.
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.