Root ca #261
Merged
Root ca #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made all these changes so that Greengrass Secure Tunneling component would work. I agree we should update the README but the rest of the changes are just undoing the changes that fixed Greengrass. |
shangabl
previously approved these changes
May 9, 2022
RogerZhongAWS
requested changes
May 9, 2022
RogerZhongAWS
approved these changes
May 9, 2022
shangabl
approved these changes
May 9, 2022
RogerZhongAWS
pushed a commit
that referenced
this pull request
May 9, 2022
* updated root-ca validation to fail only if invalid path is passed. * updated the Readme file * corrected indentation errors * removed few changes since it will break GG ST binary * corrected typo
RogerZhongAWS
pushed a commit
that referenced
this pull request
May 11, 2022
* updated root-ca validation to fail only if invalid path is passed. * updated the Readme file * corrected indentation errors * removed few changes since it will break GG ST binary * corrected typo
joenghoyin
pushed a commit
to eguanatech/aws-iot-device-client-deprecated
that referenced
this pull request
Aug 29, 2023
* updated root-ca validation to fail only if invalid path is passed. * updated the Readme file * corrected indentation errors * removed few changes since it will break GG ST binary * corrected typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Validatefor this purpose.Modifications
Change summary
Please describe what changes are included in this pull request.
Validatemethod in config.cppRevision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.