Improvement to device client setup #259
Conversation
RogerZhongAWS
force-pushed
the
systemdEnhancement
branch
4 times, most recently
from
f7020b3
to
0de31d2
Compare
| chmod 644 "$CONF_OUTPUT_PATH" | ||
| printf ${GREEN} "Configuration has been successfully written to ${CONF_OUTPUT_PATH}" | ||
| fi | ||
| while [ "$CONFIRMED" != 1 ]; do |
There was a problem hiding this comment.
If user enters "n" then it will just keep asking that question without letting them to edit/correct?
There was a problem hiding this comment.
If they enter 'n' it should go back to the beginning
If they enter anything other than 'y' or 'n' it will ask the question again.
I'm mainly doing this because I have had an issue myself where I accidentally press enter and I have to enter everything over again.
There was a problem hiding this comment.
I suppose experienced users of device client will just create a config file from a template but for those who are trying it out for the first time, maybe this will help them in case they press enter by accident
RogerZhongAWS
force-pushed
the
systemdEnhancement
branch
4 times, most recently
from
b87f541
to
6acfdc3
Compare
RogerZhongAWS
force-pushed
the
systemdEnhancement
branch
from
6acfdc3
to
e947cd8
Compare
| chmod 644 "$CONF_OUTPUT_PATH" | ||
| printf ${GREEN} "Configuration has been successfully written to ${CONF_OUTPUT_PATH}" | ||
| fi | ||
| while [ "$CONFIRMED" != 1 ]; do |
There was a problem hiding this comment.
If user enters "n" then it will just keep asking that question without letting them to edit/correct?
Motivation
Modifications
Change summary
Change fixes the issue, updates documentation and added a small QOL improvement in the setup script (when confirming config file, will no longer loop to the very beginning if the user hits the Enter key without specifying 'y' or 'n'
Testing
Manually tested ./setup.sh
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.