Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for pub sub creation #214

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Bug fix for pub sub creation #214

merged 4 commits into from
Feb 4, 2022

Conversation

xlcheng1
Copy link
Contributor

Motivation

  • if pubFile and subFile is empty, the MQTT will not publish default on the terminal
  • Issue number: 211

Modifications

Change summary

Please describe what changes are included in this pull request.

Revision diff summary

If there is more than one revision, please explain what has been changed since the last revision.

Testing

Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.

  • CI test run result:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@HarshGandhi-AWS HarshGandhi-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

Copy link
Contributor

@marcoemorais-aws marcoemorais-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that leak is resolved with valgrind. 👍

@xlcheng1 xlcheng1 merged commit 817cd3a into main Feb 4, 2022
@xlcheng1 xlcheng1 deleted the bugFixForPubSubCreation branch February 4, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants