Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chomp is removing trailing newlines. #142

Closed
burkaygur opened this issue Mar 16, 2018 · 3 comments
Closed

chomp is removing trailing newlines. #142

burkaygur opened this issue Mar 16, 2018 · 3 comments
Milestone
v3.0

Comments

@burkaygur
Copy link

https://github.com/awslabs/aws-fluent-plugin-kinesis/blob/master/lib/fluent/plugin/kinesis.rb#L108

Here, the additional formatting - chomp - is causing newlines to be removed that the JSON formatter is adding by default. I think at this point we should rely on the formatter and not do any post-processing.
geofffranks pushed a commit to geofffranks/aws-fluent-plugin-kinesis that referenced this issue Apr 26, 2018
@acur9 @teancom
Don't chomp formatted messages. Fixes awslabs#142
6f5a019 
Signed-off-by: David Bishop <[email protected]>
@riywo riywo mentioned this issue Feb 4, 2019
Closed
simukappu added a commit that referenced this issue Feb 17, 2019
@simukappu
Add chomp_records option for compatible format with plugin v2 - #142
715dced
simukappu added a commit to simukappu/aws-fluent-plugin-kinesis that referenced this issue Feb 17, 2019
@simukappu
Add chomp_record option for compatible format with plugin v2 - awslab…
2ff21f1 
…s#142
simukappu added a commit to simukappu/aws-fluent-plugin-kinesis that referenced this issue Feb 17, 2019
@simukappu
Add chomp_record option for compatible format with plugin v2 - awslab…
5824442 
…s#142
simukappu added a commit to simukappu/aws-fluent-plugin-kinesis that referenced this issue Feb 17, 2019
@simukappu
Add chomp_record option for compatible format with plugin v2 - awslab…
5b9a4fc 
…s#142
@riywo riywo added this to the v3.0 milestone Feb 18, 2019
This was referenced Feb 18, 2019
Merged
Merged
@riywo
Copy link
Contributor

riywo commented Feb 24, 2019

Just released v3.0.0.rc.2.0 which doesn't chomp by default. Please try it out and give us feedback! https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.0.0.rc.2.0

@simukappu
Copy link
Contributor

We will publish v3.0.0 next week unless we get any trouble feedback. We are appreciate your patience.

@simukappu simukappu mentioned this issue Mar 18, 2019
Merged
@riywo
Copy link
Contributor

riywo commented Mar 19, 2019

Today, we've released v3.0.0 in rubygems. https://rubygems.org/gems/fluent-plugin-kinesis/versions/3.0.0

@riywo riywo closed this as completed Mar 19, 2019
@brenno-passanha brenno-passanha mentioned this issue Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@riywo @burkaygur @simukappu