Simplify error handling in MetricScope wrapper #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`metricScope` now lets the regular try-catch-finally semantics be responsible for propagating any errors from the handler instead of rethrowing them manually. This allows the wrapper's return type to mirror the handler more accurately, eliminating the `| undefined`.
|
Thanks for the PR! The build hit DockerHub limits, but passed on retry. |
jaredcnance
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
metricScopenow lets the regular try-catch-finally semantics beresponsible for propagating any errors from the handler instead of
rethrowing them manually. This allows the wrapper's return type to
mirror the handler more accurately, eliminating the
| undefined.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.