Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High Resolution Metrics Support #142

Merged
merged 16 commits into from
Jan 23, 2023
Merged

High Resolution Metrics Support #142

merged 16 commits into from
Jan 23, 2023

Conversation

meshwa19
Copy link
Contributor

@meshwa19 meshwa19 commented Jan 3, 2023 •
edited
Loading

Description of changes:

  • Added support for High Resolution Metrics. Customers can specify an optional property - storageResolution of the metrics in putMetric() call. If resolution is not specified, metrics will be emitted with standard resolution.
  • Added UTs and modified integration tests for the changes.
  • Updated README.md and examples folder.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rayabagi
rayabagi reviewed Jan 10, 2023
View reviewed changes
src/logger/MetricsContext.ts Show resolved Hide resolved
src/logger/__tests__/MetricsContext.test.ts Outdated Show resolved Hide resolved
examples/lambda/src/index.js Outdated Show resolved Hide resolved
rayabagi
rayabagi approved these changes Jan 13, 2023
View reviewed changes
Copy link

@rayabagi rayabagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished with the review.

@markkuhn markkuhn added the enhancement New feature or request label Jan 13, 2023
@markkuhn
Copy link
Contributor

markkuhn commented Jan 13, 2023 •
edited
Loading

Should we add information about StorageResolution in the README? Maybe the 2 types of resolution and a link to the relevant wiki?

@markkuhn
Copy link
Contributor

nit: run prettier formatting on all your changes

markkuhn
markkuhn reviewed Jan 13, 2023
View reviewed changes
src/logger/MetricsContext.ts Outdated Show resolved Hide resolved
src/utils/Validator.ts Show resolved Hide resolved
src/logger/__tests__/MetricsContext.test.ts Outdated Show resolved Hide resolved
src/serializers/LogSerializer.ts Outdated Show resolved Hide resolved
src/utils/Validator.ts Outdated Show resolved Hide resolved
test/integ/agent/end-to-end.integ.ts Outdated Show resolved Hide resolved
@meshwa19
Copy link
Contributor Author

nit: run prettier formatting on all your changes

Done!

markkuhn
markkuhn approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@markkuhn markkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@meshwa19 meshwa19 merged commit c00790b into awslabs:master Jan 23, 2023
@giancarlokc giancarlokc mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markkuhn markkuhn markkuhn approved these changes

@rayabagi rayabagi rayabagi approved these changes

@giancarlokc giancarlokc Awaiting requested review from giancarlokc

Assignees

@meshwa19 meshwa19

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meshwa19 @markkuhn @rayabagi