Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent putDimensions from storing duplicate dimensions #104

Merged
merged 3 commits into from
Aug 12, 2022

Commits on Nov 22, 2021

  1. fix: prevent putDimensions from storing duplicate dimensions

    Conditions previously checked for any dimension set which did not match
    before adding the input dimension set.
    
    This would allow different-sized dimension sets from being mistaken
    as non-duplicate and being added (see unit test for example).
    
    New conditions check for any dimension set which does match
    before skipping adding the input dimension set to the collection.
    
    [TESTING]
    
    Unit test updated to address edge case;
    multiple dimension sets of variable size are added and checked.
    Aaron Michael Lamb committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    8a07c48 View commit details
    Browse the repository at this point in the history
  2. fix: change putDimensions to update/sort existing dimension sets when…

    … duplicate
    
    This change ensures new dimension key-values are used for the EMF root node
    by removing duplicate dimension sets and adding input dimension set to the
    end of the collection.
    
    Example:
    
    ```
    [
      { "keyA": "value1" },
      { "keyA": "value2" },
    ]
    
    // expected EMF target member: { "keyA": "value2 }
    ```
    
    [TESTING]
    
    Updated unit tests to check for this chase wherein putDimensions
    may be triggered using various dimension set lengths, values, and order.
    Aaron Michael Lamb committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    a9705f2 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Configuration menu
    Copy the full SHA
    da7cf71 View commit details
    Browse the repository at this point in the history