Expose S3 Request Metrics #928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
reviewed
Oct 31, 2025
src/native/s3_client.c
Outdated
| return AWS_OP_SUCCESS; | ||
| } | ||
|
|
||
| static jobject s_get_error_type_enum(JNIEnv *env, int error_code) { |
Contributor
There was a problem hiding this comment.
I'll vote for a generic API in the exception class. And replace the isErrorRetryable in HTTP as well
azkrishpy
force-pushed
the
expose-metrics
branch
from
e1ad094 to
8ff35ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#806
Description of changes:
Exposes S3 Request Metrics from the CRT S3 Client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.