Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lambda): renamed the lambda.Runtime enum values from NodeJS to Nodejs #2815

Merged
merged 4 commits into from
Jun 12, 2019

Conversation

shivlaks
Copy link
Contributor

Addresses the consistency of casing for runtime for other target languages.
in Python, this was previously NODE_J_S and now it will be NODEJS

BREAKING CHANGE:

  • lambda: lambda.Runtime.NodeJS* are now lambda.Runtime.Nodejs

Fixes #980


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

…to Nodejs

Addresses the consistency of casing for runtime for other target languages.
Previously (NodeJS was NODE_J_S in Python. After this change, Nodejs is now NODEJS.)

Fixes #960
@shivlaks shivlaks requested a review from a team June 11, 2019 06:17
@shivlaks shivlaks merged commit 10c37dd into master Jun 12, 2019
ScOut3R pushed a commit to ScOut3R/aws-cdk that referenced this pull request Jun 13, 2019
…to Nodejs (aws#2815)

Addresses the consistency of casing for runtime for other target languages.
in Python, this was previously `NODE_J_S` and now it will be `NODEJS`

**Fixes aws#980**

BREAKING CHANGE:
* **lambda:** `lambda.Runtime.NodeJS*` are now `lambda.Runtime.Nodejs*`
@shivlaks shivlaks deleted the shivlaks/fix-lambda-runtime-names branch June 19, 2019 02:34
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix capitalization of lambda.Runtime names
3 participants