Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apigateway: should be possible to define part of the URLspace as a construct, also middleware #960

Closed
rix0rrr opened this issue Oct 18, 2018 · 2 comments
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 18, 2018

For example, it should be possible to have a set of related urls:

.../users (GET)
.../users (POST)
.../users/{id} (GET)

(Or whatever)
And define the group of resources, methods and handlers as a single resource. Consumers should be able to mount these at an arbitrary point in their URL space, hopefully looking like this:

restApi.root.addResource('users', new UserManager(this, 'UserManager'));

(UserManager is then free to contain Lambdas, Dynamo tables and whatnot)

It should also be able to wrap an inner urlspace construct in some useful way (like the logger middleware example from the workshop)

@rix0rrr rix0rrr changed the title apigateway: should be possible to define part of the URLspace as a construct apigateway: should be possible to define part of the URLspace as a construct, also middleware Oct 18, 2018
@rix0rrr rix0rrr added the feature-request A feature should be added or improved. label Nov 6, 2018
@debora-ito debora-ito added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Nov 8, 2018
shivlaks added a commit that referenced this issue Jun 10, 2019
…to Nodejs

Addresses the consistency of casing for runtime for other target languages.
Previously (NodeJS was NODE_J_S in Python. After this change, Nodejs is now NODEJS.)

Fixes #960
@eladb eladb self-assigned this Aug 12, 2019
@eladb eladb assigned nija-at and unassigned eladb Sep 3, 2019
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Sep 27, 2019

Don't know if this already possible with the current API, still feel it would be a good idea to support this.

@nija-at nija-at added the effort/large Large work item – several weeks of effort label Mar 4, 2020
@nija-at nija-at added the p2 label Sep 2, 2020
@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 6, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

5 participants