Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all "export" methods #2458

Closed
eladb opened this issue May 2, 2019 · 0 comments · Fixed by #2580
Closed

Remove all "export" methods #2458

eladb opened this issue May 2, 2019 · 0 comments · Fixed by #2580
Assignees

Comments

@eladb
Copy link
Contributor

eladb commented May 2, 2019

No description provided.

@eladb eladb added the may-15 label May 14, 2019
eladb pushed a commit that referenced this issue May 18, 2019
Implemented an awslint rule to help identify all "export" methods and remove them.

Align all AWS resource constructs (besides `events.EventRule`) to their canonical name.

Fixes #2577
Fixes #2578
Fixes #2458
Fixes #2419
Fixes #2579
Fixes #2313

Related #2551

BREAKING CHANGE: All `export` methods from all AWS resources have been removed. CloudFormation Exports are now automatically created when attributes are referenced across stacks within the same app. To export resources manually, you can explicitly define a `CfnOutput`.
* `kms.EncryptionKey` renamed to `kms.Key`
* `ec2.VpcNetwork` renamed to `ec2.Vpc`
* `ec2.VpcSubnet` renamed to `ec2.Subnet`
* `cloudtrail.CloudTrail` renamed `to `cloudtrail.Trail`
* Deleted a few `XxxAttribute` and `XxxImportProps` interfaces which were no longer in used after their corresponding `export` method was deleted and there was no use for them in imports.
* `ecs.ClusterAttributes` now accepts `IVpc` and `ISecurityGroup` instead of attributes. You can use their
corresponding `fromXxx` methods to import them as needed.
* `servicediscovery.CnameInstance.instanceCname` renamed to `cname`.
* `glue.IDatabase.locationUrl` is now only in `glue.Database` (not on the interface)
* `ec2.TcpPortFromAttribute` and `UdpPortFromAttribute` removed. Use `TcpPort` and `UdpPort` with `new Token(x).toNumber` instead.
* `ec2.VpcNetwork.importFromContext` renamed to `ec2.Vpc.fromLookup`
* `iam.IRole.roleId` has been removed from the interface, but `Role.roleId` is still available for owned resources.
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant