-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove "export"s and normalize resource names #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `iam.IRole.export` has been removed. * `iam.RoleAttributes` has been removed. * `iam.IRole.roleId` has been removed. `Role.roleId` is still available for owned resources.
* `events.EventRuleAttributes` has been removed. * `events.IEventRule.export` has been removed.
BREAKING CHANGE: * `ec2.VpcNetwork` and all related classes renamed to `ec2.Vpc` * `ec2.VpcSubnet` and all related classes renamed to `ec2.Subnet` * `import` static methods replaced by `fromXxx` * `ec2.TcpPortFromAttribute` and `UdpPortFromAttribute` removed. Use `TcpPort` and `UdpPort` with `Token.toNumber` instead. * `ec2.SecurityGroupAttributes` removed * `ec2.VpcNetwork.importFromContext` renamed to `ec2.Vpc.fromLookup`
BREAKING CHANGE: * `cloudtrail.CloudTrail` renamed to `Trail`
fix key reference
canInline based on tokens
* `certificatemanager.CertificateAttributes` removed.
* `codebuild.ProjectAttributes` removed
* `servicediscovery.CnameInstance.instanceCname` renamed to `cname`. * `servicediscovery.
rix0rrr
approved these changes
May 18, 2019
This was referenced Aug 22, 2019
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented an awslint rule to help identify all "export" methods and remove them.
Align all AWS resource constructs (besides
events.EventRule
) to their canonical name.Fixes #2577
Fixes #2578
Fixes #2458
Fixes #2419
Fixes #2579
Fixes #2313
Related #2551
BREAKING CHANGE: All
export
methods from all AWS resources have been removed. CloudFormation Exports are now automatically created when attributes are referenced across stacks within the same app. To export resources manually, you can explicitly define aCfnOutput
.kms.EncryptionKey
renamed tokms.Key
ec2.VpcNetwork
renamed toec2.Vpc
ec2.VpcSubnet
renamed toec2.Subnet
cloudtrail.CloudTrail
renamedto
cloudtrail.Trail`XxxAttribute
andXxxImportProps
interfaces which were no longer in used after their correspondingexport
method was deleted and there was no use for them in imports.ecs.ClusterAttributes
now acceptsIVpc
andISecurityGroup
instead of attributes. You can use theircorresponding
fromXxx
methods to import them as needed.servicediscovery.CnameInstance.instanceCname
renamed tocname
.glue.IDatabase.locationUrl
is now only inglue.Database
(not on the interface)ec2.TcpPortFromAttribute
andUdpPortFromAttribute
removed. UseTcpPort
andUdpPort
withnew Token(x).toNumber
instead.ec2.VpcNetwork.importFromContext
renamed toec2.Vpc.fromLookup
iam.IRole.roleId
has been removed from the interface, butRole.roleId
is still available for owned resources.Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.