Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert all enums to UPPER_CASE (jsii?) #2287

Closed
1 task
eladb opened this issue Apr 15, 2019 · 0 comments · Fixed by #2918 or #2989
Closed
1 task

convert all enums to UPPER_CASE (jsii?) #2287

eladb opened this issue Apr 15, 2019 · 0 comments · Fixed by #2918 or #2989
Labels
effort/medium Medium work item – several days of effort package/awscl Cross-cutting issues related to the AWS Construct Library

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019 •
edited by shivlaks
Loading

  • Convert enums to UPPER_CASE
@eladb eladb added feature-request A feature should be added or improved. package/awscl Cross-cutting issues related to the AWS Construct Library effort/medium Medium work item – several days of effort and removed feature-request A feature should be added or improved. labels Apr 15, 2019
@eladb eladb changed the title Guidelines implementation: Naming convert all enums to UPPER_CASE (jsii?) May 1, 2019
@eladb eladb added package/awscl Cross-cutting issues related to the AWS Construct Library and removed package/awscl Cross-cutting issues related to the AWS Construct Library labels May 1, 2019
@eladb eladb added the may-15 label May 14, 2019
@shivlaks shivlaks self-assigned this May 31, 2019
@shivlaks shivlaks mentioned this issue Jun 19, 2019
Merged
4 tasks
shivlaks added a commit that referenced this issue Jun 20, 2019
@shivlaks
refactor: update all enum members to be UPPER_CASE (#2918)
dbf3e17 
Updating enum members in all constructs to be UPPER_CASE.

This is in accordance with the new construct library guidelines.

**Fixes #2287**

BREAKING CHANGE: all enum members were changed from `PascalCase` to `TRUMP_CASE`
shivlaks added a commit to aws/jsii that referenced this issue Jun 20, 2019
@shivlaks
feat(jsii): enforce enum member names to be ALL_CAPS (#541)
c88080d 
Language generators will override as needed for language-specific idiomacy.

BREAKING CHANGE: Enum members are now expected to be `ALL_CAPS`

Fixes aws/aws-cdk#2287
shivlaks added a commit that referenced this issue Jun 21, 2019
@shivlaks
refactor: update all enum members to be ALL_CAPS - part II
d9ed2e3 
Updated enum members in core modules, drift from recent merges, and packages
that were missed in the first pass.

This is in accordance with the new construct library guidelines.

**Fixes #2287**

BREAKING CHANGE: all enum members were changed from `PascalCase` to `ALL_CAPS`
@shivlaks shivlaks mentioned this issue Jun 21, 2019
Merged
4 tasks
shivlaks added a commit that referenced this issue Jun 21, 2019
@shivlaks
refactor: update all enum members to be ALL_CAPS - part II (#2989)
ba6a165 
Updated enum members in core modules, drift from recent merges, and packages
that were missed in the first pass.

This is in accordance with the new construct library guidelines.

**Fixes #2287**

BREAKING CHANGE: all enum members were changed from `PascalCase` to `ALL_CAPS`
@mhuebner mhuebner mentioned this issue Jun 26, 2019
Closed
1 task
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
This was referenced Dec 12, 2019
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort package/awscl Cross-cutting issues related to the AWS Construct Library
Projects
None yet
Milestone
No milestone
2 participants
@eladb @shivlaks