Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update all enum members to be ALL_CAPS - part II #2989

Merged
merged 5 commits into from
Jun 21, 2019

Conversation

shivlaks
Copy link
Contributor

Updated enum members in core modules, drift from recent merges, and packages
that were missed in the first pass.

This is in accordance with the new construct library guidelines.

Fixes #2287

BREAKING CHANGE: all enum members were changed from PascalCase to ALL_CAPS


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Updated enum members in core modules, drift from recent merges, and packages
that were missed in the first pass.

This is in accordance with the new construct library guidelines.

**Fixes #2287**

BREAKING CHANGE: all enum members were changed from `PascalCase` to `ALL_CAPS`
@shivlaks shivlaks requested a review from a team June 21, 2019 10:47
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 21, 2019

drift from recent merges

How is that possible? Did we not have a linter rule to prevent new incoming drift?

@shivlaks
Copy link
Contributor Author

drift from recent merges

How is that possible? Did we not have a linter rule to prevent new incoming drift?

It's being enforced at the jsii level - so it's from testing locally against the latest in jsii :)

@shivlaks shivlaks merged commit ba6a165 into master Jun 21, 2019
@shivlaks shivlaks deleted the shivlaks/upper-case-enum-members-part-deux branch June 24, 2019 04:28
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert all enums to UPPER_CASE (jsii?)
3 participants