Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codebuild): add support for more image types #2233

Merged
merged 3 commits into from
Apr 11, 2019
Merged

feat(codebuild): add support for more image types #2233

merged 3 commits into from
Apr 11, 2019

Conversation

Kaixiang-AWS
Copy link
Contributor

@Kaixiang-AWS Kaixiang-AWS commented Apr 10, 2019 •
edited
Loading

Add support for the following images

aws/codebuild/golang:1.11
aws/codebuild/docker:18.09.0
aws/codebuild/java:openjdk-11
aws/codebuild/nodejs:10.14.1
aws/codebuild/php:7.1
aws/codebuild/python:3.7.1
aws/codebuild/ruby:2.5.3
aws/codebuild/standard:1.0

and default UBUNTU_18_04_STANDARD_1_0 as the build image

Fixes #2079

BREAKING CHANGE: change the default image from UBUNTU_14_04_BASE to UBUNTU_18_04_STANDARD_1_0
If you want to keep the behavior as previous, please explicitly specify image as UBUNTU_14_04_BASE

Pull Request Checklist

  • [Y] Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • [Y] Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • [Y] Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • [N] Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@Kaixiang-AWS
feat(codebuild): add support for more image types
1528941 
Add support for aws/codebuild/golang:1.11 and aws/codebuild/standard:1.0
and default UBUNTU_18_04_STANDARD as the build image

Fixes aws#2079

BREAKING CHANGE: change the default image from UBUNTU_14_04_BASE to UBUNTU_18_04_STANDARD
If you want to keep the behavior as previous, please explicitly specify image as UBUNTU_14_04_BASE
skinny85
skinny85 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Just one small ask.

packages/@aws-cdk/aws-codebuild/lib/project.ts Show resolved Hide resolved
@skinny85 skinny85 merged commit 87b1ea0 into aws:master Apr 11, 2019
@Kaixiang-AWS Kaixiang-AWS deleted the new-image branch May 14, 2019 04:14
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support aws/codebuild/golang:1.11 build image
2 participants
@Kaixiang-AWS @skinny85