Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support aws/codebuild/golang:1.11 build image #2079

Closed
rvdwijngaard opened this issue Mar 22, 2019 · 2 comments · Fixed by #2233 · May be fixed by MechanicalRock/account-reaper#6
Closed

support aws/codebuild/golang:1.11 build image #2079

rvdwijngaard opened this issue Mar 22, 2019 · 2 comments · Fixed by #2233 · May be fixed by MechanicalRock/account-reaper#6
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@rvdwijngaard
Copy link

Currently cdk only supports codebuild golang 1.10 image. ; please add support for golang 1.11.
@skinny85 skinny85 added @aws-cdk/aws-codebuild Related to AWS CodeBuild good first issue Related to contributions. See CONTRIBUTING.md feature-request A feature should be added or improved. labels Mar 22, 2019
@skinny85
Copy link
Contributor

Thanks for reporting @rvdwijngaard ! In the meantime, you can use codebuild.LinuxBuildImage.fromDockerHub('aws/codebuild/golang:1.11') to unblock yourself.

@skinny85 skinny85 added the effort/small Small work item – less than a day of effort label Mar 23, 2019
@rvdwijngaard
Copy link
Author

@skinny85 thanks for your suggestion.

Kaixiang-AWS added a commit to Kaixiang-AWS/aws-cdk that referenced this issue Apr 10, 2019
@Kaixiang-AWS
feat(codebuild): add support for more image types
1528941 
Add support for aws/codebuild/golang:1.11 and aws/codebuild/standard:1.0
and default UBUNTU_18_04_STANDARD as the build image

Fixes aws#2079

BREAKING CHANGE: change the default image from UBUNTU_14_04_BASE to UBUNTU_18_04_STANDARD
If you want to keep the behavior as previous, please explicitly specify image as UBUNTU_14_04_BASE
@Kaixiang-AWS Kaixiang-AWS mentioned this issue Apr 10, 2019
Merged
skinny85 pushed a commit that referenced this issue Apr 11, 2019
@Kaixiang-AWS @skinny85
feat(codebuild): add support for more images (#2233)
87b1ea0 
Updates to the newest versions of the Ubuntu 14.04 images for Go, Java, Ruby and Python.
Also adds the new Ubuntu 18.04 Standard image.

BREAKING CHANGE: change the default image from UBUNTU_14_04_BASE to UBUNTU_18_04_STANDARD.

Fixes #2079
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
2 participants
@skinny85 @rvdwijngaard