fix(aws-cdk): FSharp template version upgrade. #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the FSharp code to be compatable with the latest changes in the aws-cdk. Added code files to fsproj.
|
I tested the (changed) packaged cdk executable locally and it now synthesizes from init-state. |
eladb
approved these changes
Mar 13, 2019
| @@ -17,5 +17,5 @@ type MyStack(scope, name, props) as this = | |||
| let user = User(this, "MyUser", UserProps()) | |||
|
|
|||
| do | |||
| topic.SubscribeQueue(queue) |> ignore | |||
| topic.SubscribeQueue(queue, Nullable false) |> ignore | |||
There was a problem hiding this comment.
:-( we still don't have support for optional arguments in .NET?
There was a problem hiding this comment.
Was about to open a PR for these exact same changes, beat me to it.
BTW I was using Nullable(type) instead of Nullable type, not fussed with one over the other (barely use Nullable in F# anyway) but should try to stick to one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the FSharp code to be compatable with the latest changes in the aws-cdk.
Added code files to fsproj.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.