Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-cdk): FSharp template version upgrade. #2006

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix(aws-cdk): FSharp template version upgrade. #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/aws-cdk/lib/init-templates/app/fsharp/src/HelloCdk/HelloCdk.template.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
<TargetFramework>netcoreapp2.1</TargetFramework>
</PropertyGroup>

<ItemGroup>
<Compile Include="HelloConstruct.fs" />
<Compile Include="HelloStack.fs" />
<Compile Include="Program.fs" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Amazon.CDK" Version="%cdk-version%" />
<PackageReference Include="Amazon.CDK.AWS.IAM" Version="%cdk-version%" />
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/init-templates/app/fsharp/src/HelloCdk/HelloStack.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ type MyStack(scope, name, props) as this =
let user = User(this, "MyUser", UserProps())

do
topic.SubscribeQueue(queue) |> ignore
topic.SubscribeQueue(queue, Nullable false) |> ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-( we still don't have support for optional arguments in .NET?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was about to open a PR for these exact same changes, beat me to it.
BTW I was using Nullable(type) instead of Nullable type, not fussed with one over the other (barely use Nullable in F# anyway) but should try to stick to one.

hello.GrantRead(user)
4 changes: 2 additions & 2 deletions packages/aws-cdk/lib/init-templates/app/fsharp/src/HelloCdk/Program.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ open HelloCdk

[<EntryPoint>]
let main _ =
let app = App()
let app = App(null)
MyStack(app, "hello-cdk-1", StackProps()) |> ignore
MyStack(app, "hello-cdk-2", StackProps()) |> ignore
app.Run()
app.Run() |> ignore
0