error handling improvements #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Was this based off of #106?
See some concerning differences/omissions for starters.
sfod
reviewed
Apr 17, 2024
sfod
reviewed
Apr 17, 2024
It was started separately and some significant changes were made before I realized you'd done a pass. I reviewed your in-progress and tried to address the comments you had left. Definitely possible I missed some but I thought I nabbed em all. |
bretambrose
reviewed
Jun 18, 2024
bretambrose
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise errors and log for more accurate error handling and reporting.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.