Always set the symbol visibility preset to hidden. #1143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #1142
Description of changes:
This PR updates
AwsCFlags.cmake
to always pass-fvisibility=hidden
to the targets, even when we are building static libraries. Instead of directly specifying the compiler option, we use theVISIBILITY_PRESET
CMake property, for increased portability across compilers.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.