Skip to content

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Sep 4, 2025

Issue #, if available:

  • The sts_web_identity double frees the connection to connection manager. And causes a fatal warning and should be an error. But looks like nothing in code actually makes it to fail.

Description of changes:

  • Add a count in the mock connection manager to make sure those connection are acquired and released correctly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.29%. Comparing base (5224ea9) to head (5f24f78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   81.29%   81.29%   -0.01%     
==========================================
  Files          33       33              
  Lines        6250     6248       -2     
==========================================
- Hits         5081     5079       -2     
  Misses       1169     1169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK merged commit ab03bdd into main Sep 4, 2025
37 checks passed
@TingDaoK TingDaoK deleted the fix-sts-web branch September 4, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants