Improving Retries based on Iceberg Integration Feedback#321
Merged
fuatbasik merged 5 commits intoawslabs:mainfrom Jul 24, 2025
Merged
Improving Retries based on Iceberg Integration Feedback#321fuatbasik merged 5 commits intoawslabs:mainfrom
fuatbasik merged 5 commits intoawslabs:mainfrom
Conversation
fuatbasik
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
ozkoca
reviewed
Jul 23, 2025
common/src/main/java/software/amazon/s3/analyticsaccelerator/util/retry/IORunnable.java
Show resolved
Hide resolved
| * @return result of the supplier | ||
| * @throws IOException if the operation fails after all retry attempts | ||
| */ | ||
| byte[] get(IOSupplier supplier) throws IOException; |
Collaborator
There was a problem hiding this comment.
In new PhysicalIO branch, we are using ObjectContent and void as return type of this method. With changing this method/interface non-generic, how can we create a strategy for the operations which are not expecting byte[]?
Collaborator
Author
There was a problem hiding this comment.
this is now resolved by moving supplier to return a type T instead of byte []
fuatbasik
had a problem deploying
to
integration-tests
GitHub Actions
Failure
fuatbasik
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
ozkoca
previously approved these changes
Jul 24, 2025
stubz151
reviewed
Jul 24, 2025
| * | ||
| * @return the Failsafe RetryPolicy for byte arrays | ||
| */ | ||
| dev.failsafe.RetryPolicy<Object> getDelegate(); |
Contributor
There was a problem hiding this comment.
shouldn't this be byte[]? Whenever I see Object as a type I get worried.
| * @return this builder instance | ||
| */ | ||
| public RetryPolicyBuilder withMaxRetries(int maxRetries) { | ||
| delegateBuilder.withMaxRetries(maxRetries); |
Contributor
There was a problem hiding this comment.
should there not be a precondition here and on the withDelay below
| * Retry strategy implementation for seekable input stream operations. Uses Failsafe library to | ||
| * execute operations with configurable retry policies. | ||
| */ | ||
| public class SeekableInputStreamRetryStrategy implements RetryStrategy { |
Contributor
There was a problem hiding this comment.
nit: something I should have picked up during the original but are we happy with this class name? should it not be DefaultRetryStrategyImpl to follow the current pattern like DefaultLogicalIOImpl
stubz151
previously approved these changes
Jul 24, 2025
fuatbasik
had a problem deploying
to
integration-tests
GitHub Actions
Failure
fuatbasik
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
stubz151
approved these changes
Jul 24, 2025
ozkoca
approved these changes
Jul 24, 2025
ozkoca
added a commit
that referenced
this pull request
Jul 25, 2025
## Description of change This PR rebases ant integrates the changes in PR #321 #### Relevant issues #286 #287 #288 #289 #294 #316 #320 #### Does this contribution introduce any breaking changes to the existing APIs or behaviors? No #### Does this contribution introduce any new public APIs or behaviors? No #### How was the contribution tested? Unit tests --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/).
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Sep 3, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `analyticsaccelerator-s3` to 1.3.0. ### Why are the changes needed? To use the latest improvements and bug fixes for Apache Spark 4.1.0. - https://github.com/awslabs/analytics-accelerator-s3/releases/tag/v1.3.0 - awslabs/analytics-accelerator-s3#345 - awslabs/analytics-accelerator-s3#338 - awslabs/analytics-accelerator-s3#321 - awslabs/analytics-accelerator-s3#342 ### Does this PR introduce _any_ user-facing change? No, this was a new library which is not released yet. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52203 from dongjoon-hyun/SPARK-53460. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `analyticsaccelerator-s3` to 1.3.0. ### Why are the changes needed? To use the latest improvements and bug fixes for Apache Spark 4.1.0. - https://github.com/awslabs/analytics-accelerator-s3/releases/tag/v1.3.0 - awslabs/analytics-accelerator-s3#345 - awslabs/analytics-accelerator-s3#338 - awslabs/analytics-accelerator-s3#321 - awslabs/analytics-accelerator-s3#342 ### Does this PR introduce _any_ user-facing change? No, this was a new library which is not released yet. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52203 from dongjoon-hyun/SPARK-53460. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
After trying to integrated RetryStrategy with S3FileIO, I realised we exposed too much details (i.e. return types of methods to retry) to customers. Also, it was not possible to pass Retry strategy down to Block. With this change I make
1/ Move Retry module to common to co-locate it with OpenStreamInformation. This way, we can pass RetryStrategy down to block.
2/ We move away from Generic types on IOSupplier, instead only support methods that return byte[] and throws IOException now (or voids through IORunnable). This way, consumers do not need to know about the return types.
3/Update relevant javadocs
Relevant issues
N/A
Does this contribution introduce any breaking changes to the existing APIs or behaviors?
No. Retries were already internal only.
Does this contribution introduce any new public APIs or behaviors?
Yes, with this change, we can now pass RetryStrategy to OpenStreamInformation that would instruct AAL to handle retries of certain failures up to a predefined number of times.
How was the contribution tested?
new unit tests are added. All existing tests, including gray failure tests are passing.
Does this contribution need a changelog entry?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).