Added iostats get request callback to streamReader#317
Merged
ozkoca merged 2 commits intoawslabs:physical-io-featurefrom Jul 15, 2025
Merged
Conversation
vaibhav5140
reviewed
Jul 14, 2025
| verify(mockMetrics).add(MetricKey.GET_REQUEST_COUNT, 1); | ||
| verifyNoMoreInteractions(mockMetrics); | ||
| verify(block).setData(testData); | ||
| verify(mockOpenStreamInfo.getRequestCallback(), times(1)).onGetRequest(); |
Contributor
There was a problem hiding this comment.
I think we can create mock callback directly and create real OpenStreamInformation with mock callback
OpenStreamInformation openStreamInfo = OpenStreamInformation.builder()
.requestCallback(mockCallback)
.build();
Collaborator
Author
There was a problem hiding this comment.
addressed in the next commit
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jul 21, 2025
Added iostats get request callback to streamReader (awslabs#317) This PR moves IOStat callback method request from Block to StreamReader. Needs to be done as part of code rebase --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Telemetry support for physical IO (awslabs#318) This PR adds telemetry measures for StreamReader and BlockManager.
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jul 23, 2025
Added iostats get request callback to streamReader (awslabs#317) This PR moves IOStat callback method request from Block to StreamReader. Needs to be done as part of code rebase --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Telemetry support for physical IO (awslabs#318) This PR adds telemetry measures for StreamReader and BlockManager.
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jul 25, 2025
Added iostats get request callback to streamReader (awslabs#317) This PR moves IOStat callback method request from Block to StreamReader. Needs to be done as part of code rebase --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Telemetry support for physical IO (awslabs#318) This PR adds telemetry measures for StreamReader and BlockManager. Introducing retry policy to new PhysicalIO (awslabs#320) This PR adds the capability of retry to the new PhysicalIO awslabs#286 awslabs#287 awslabs#288 awslabs#289 awslabs#294 awslabs#316 existing APIs or behaviors? No No Unit tests --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/).
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jul 25, 2025
Added iostats get request callback to streamReader (awslabs#317) This PR moves IOStat callback method request from Block to StreamReader. Needs to be done as part of code rebase --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Telemetry support for physical IO (awslabs#318) This PR adds telemetry measures for StreamReader and BlockManager. Introducing retry policy to new PhysicalIO (awslabs#320) This PR adds the capability of retry to the new PhysicalIO awslabs#286 awslabs#287 awslabs#288 awslabs#289 awslabs#294 awslabs#316 existing APIs or behaviors? No No Unit tests --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR moves IOStat callback method request from Block to StreamReader. Needs to be done as part of code rebase
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).