Add Retries and Retry Policy #307
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package software.amazon.s3.analyticsaccelerator.retry; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| /** | ||
| * Interface for executing operations with retry logic. We do not expect consumers of AAL to | ||
|
||
| * instantiate an implementation of this interface themselves. This is for AAL's internal use only. | ||
| * | ||
| * <p>This interface provides a contract for executing operations that may fail and need to be | ||
| * retried according to a configured retry policy. Implementations should handle the retry logic | ||
| * internally and only throw exceptions when all retry attempts have been exhausted. | ||
| * | ||
| * @param <R> the result type of operations executed by this retry executor | ||
| */ | ||
| public interface RetryExecutor<R> { | ||
| /** | ||
| * Executes a runnable with retry logic according to the configured retry policy. | ||
| * | ||
| * <p>The operation will be retried according to the retry policy configuration, including maximum | ||
| * retry attempts, delays between retries, and which exceptions should trigger retries. If all | ||
| * retry attempts are exhausted, the final exception will be wrapped in an IOException and thrown. | ||
| * | ||
| * @param runnable the operation to execute, which may throw IOException | ||
| * @throws IOException if the operation fails after all retry attempts are exhausted | ||
| * @throws NullPointerException if runnable is null | ||
| */ | ||
| void executeWithRetry(IORunnable runnable) throws IOException; | ||
|
|
||
| /** | ||
| * Executes a supplier with retry logic according to the configured retry policy. | ||
| * | ||
|
Contributor
There was a problem hiding this comment. these 2 lines are basically saying the same thing about using the retry policy maybe just merge them? |
||
| * <p>The operation will be retried according to the retry policy configuration, including maximum | ||
| * retry attempts, delays between retries, and which exceptions should trigger retries. If all | ||
| * retry attempts are exhausted, the final exception will be wrapped in an IOException and thrown. | ||
| * | ||
| * @param supplier the operation to execute, returns <R>, may throw IOException | ||
| * @return R result of the supplier. | ||
| * @throws IOException if the operation fails due to an I/O error | ||
| */ | ||
| R getWithRetry(IOSupplier<R> supplier) throws IOException; | ||
|
|
||
| /** Functional interface for operations that can throw IOException. */ | ||
| @FunctionalInterface | ||
| interface IORunnable { | ||
|
Contributor
There was a problem hiding this comment. think this interface and the interface below can be handy in the future should we move them to their own classes. |
||
| /** | ||
| * Runs the operation. | ||
| * | ||
| * <p>This method should contain the logic that needs to be executed with retry support. The | ||
| * operation should be idempotent as it may be executed multiple times in case of failures. | ||
| * | ||
| * @throws IOException if the operation fails due to an I/O error | ||
| */ | ||
| void run() throws IOException; | ||
| } | ||
|
|
||
| /** Functional interface for operations that can throw IOException. */ | ||
| @FunctionalInterface | ||
| interface IOSupplier<R> { | ||
| /** | ||
| * Runs the operation. | ||
| * | ||
| * <p>This method should contain the logic that needs to be executed with retry support. The | ||
| * operation should be idempotent as it may be executed multiple times in case of failures. | ||
| * | ||
| * @return R result of the supplier. | ||
| * @throws IOException if the operation fails due to an I/O error | ||
| */ | ||
| R get() throws IOException; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.