Pass down openstreaminfo instead of streamcontext#283
Merged
ahmarsuhail merged 2 commits intoawslabs:mainfrom Jun 4, 2025
Merged
Pass down openstreaminfo instead of streamcontext#283ahmarsuhail merged 2 commits intoawslabs:mainfrom
ahmarsuhail merged 2 commits intoawslabs:mainfrom
Conversation
rajdchak
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
reviewed
Jun 4, 2025
| @NonNull BlobStore blobStore, | ||
| @NonNull Telemetry telemetry, | ||
| StreamContext streamContext, | ||
| OpenStreamInformation openStreamInformation, |
Collaborator
There was a problem hiding this comment.
we should make this @nonnull now, as a value is always passed in from the factory.
ahmarsuhail
reviewed
Jun 4, 2025
|
|
||
| @Override | ||
| public CompletableFuture<ObjectMetadata> headObject(HeadRequest headRequest) { | ||
| return headObject(headRequest, null); |
Collaborator
There was a problem hiding this comment.
why do we need headObject(HeadRequest headRequest)?
think just having headObject( HeadRequest headRequest, OpenStreamInformation openStreamInformation) is enough. same for GetObject.
rajdchak
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
reviewed
Jun 4, 2025
| public class IOPlannerTest { | ||
| private static final S3URI TEST_URI = S3URI.of("foo", "bar"); | ||
| private static final String ETAG = "RandomString"; | ||
| private static final String ETAG = "RANDOM"; |
Collaborator
There was a problem hiding this comment.
why do we need to change this?
ozkoca
added a commit
that referenced
this pull request
Jun 9, 2025
…alIO (#287) ## Description of change - This change adopts the changes from [PR](#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](#283) [Initial version of Physical IO](#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jun 26, 2025
…alIO (awslabs#287) ## Description of change - This change adopts the changes from [PR](awslabs#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](awslabs#283) [Initial version of Physical IO](awslabs#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jun 26, 2025
…alIO (awslabs#287) ## Description of change - This change adopts the changes from [PR](awslabs#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](awslabs#283) [Initial version of Physical IO](awslabs#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jun 26, 2025
…alIO (awslabs#287) ## Description of change - This change adopts the changes from [PR](awslabs#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](awslabs#283) [Initial version of Physical IO](awslabs#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jun 26, 2025
…alIO (awslabs#287) ## Description of change - This change adopts the changes from [PR](awslabs#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](awslabs#283) [Initial version of Physical IO](awslabs#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jun 26, 2025
…alIO (awslabs#287) ## Description of change - This change adopts the changes from [PR](awslabs#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](awslabs#283) [Initial version of Physical IO](awslabs#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
ozkoca
added a commit
to ozkoca/analytics-accelerator-s3
that referenced
this pull request
Jul 14, 2025
…alIO (awslabs#287) ## Description of change - This change adopts the changes from [PR](awslabs#283) to the new Physical IO implementation. - Updates comment in DataBlock object #### Relevant issues [OpenStremInformation PR](awslabs#283) [Initial version of Physical IO](awslabs#286) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Co-authored-by: Erdogan Ozkoca <ozkoca@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Relevant issues
Does this contribution introduce any breaking changes to the existing APIs or behaviors?
Does this contribution introduce any new public APIs or behaviors?
How was the contribution tested?
Does this contribution need a changelog entry?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).