Use lockfile to coordinate access to binary executable #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're running into this as well. Can someone from AWS please review and commit? |
|
Please confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
Yes, you can use, modify, copy, and redistribute this contribution. |
|
@pfifer this PR is good to go, sorry for the lag in granting you permission to use it. |
pfifer
added a commit
that referenced
this pull request
May 17, 2017
=== 0.12.4 ==== Java * Upgraded dependency on aws-java-sdk-core to 1.11.128, and removed version range. * [PR #84](#84) * [PR #106](#106) * Use an explicit lock file to manage access to the native KPL binaries. * [Issue #91](#91) * [PR #92](#92) * Log reader threads should be shut down when the native process exits. * [Issue #93](#93) * [PR #94](#94) ==== C++ Core * Add support for using a thread pool, instead of a thread per request. The thread pool model guarantees a fixed number of threads, but have issue catching up if the KPL is overloaded. * [PR #100](#100) * Add log messages, and statistics about sending data to Kinesis. * Added flush statistics that record the count of events that trigger flushes of data destined for Kinesis * Added a log message that indicates the average time it takes for a PutRecords request to be completed. This time is recorded from the when the request is enqueued to when it is completed. * Log a warning if the average request time rises above five times the configured flush interval. If you see this warning normally it indicates that the KPL is having issues keeping up. The most likely cause is to many requests being generated, and you should investigate the flush triggers to determine why flushes are being triggered. * [PR #102](#102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91
The approach of creating & locking the executable file in a non-atomic way can lead to a race condition. Instead, we should use a dedicated lockfile to coordinate access to the executable.