Auto generate protobuf C++ files #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt
Outdated
| target_include_directories(kinesis_producer SYSTEM PUBLIC ${THIRD_PARTY_INCLUDE}) | ||
| target_link_libraries(kinesis_producer ${CMAKE_THREAD_LIBS_INIT} LibProto ${AWSSDK_LINK_LIBRARIES} ${LIBBACKTRACE_LIBRARIES} ${STATIC_LIBS} ${UUID_LIBRARIES} LibSsl LibCurl) | ||
| target_link_libraries(kinesis_producer ${CMAKE_THREAD_LIBS_INIT} LibProto ${AWSSDK_LINK_LIBRARIES} ${LIBBACKTRACE_LIBRARIES} ${STATIC_LIBS} ${UUID_LIBRARIES} LibSsl LibCurl ${Protobuf_LIBRARIES}) |
There was a problem hiding this comment.
Seems like this may already part of LibProto, have you checked?
There was a problem hiding this comment.
Removed the addition and reran bootstrap and sample and it still works, so we can remove this change
| @@ -52,12 +57,6 @@ set(SOURCE_FILES | |||
| aws/kinesis/core/shard_map.h | |||
| aws/kinesis/core/user_record.cc | |||
| aws/kinesis/core/user_record.h | |||
| aws/kinesis/protobuf/config.pb.cc | |||
| aws/kinesis/protobuf/config.pb.h | |||
There was a problem hiding this comment.
Can you also add or update a .gitignore files for these generated files so that it doesnt show up as new files that need to be stashed etc?
There was a problem hiding this comment.
Updated .gitignore
akidambisrinivasan
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Remove the committed protobuf files in favor of auto generating them during bootstrap
Tested with sample producer and consumer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.