Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue after cpp sdk upgrade #600

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

chenylee-aws
Copy link
Contributor

Issue #, if available:
N/a
Description of changes:
Fix build after upgrading CPP SDK version.
The SDK upgrade caused two failures:

  1. ListShardAsync argument order is changed from listShardAsync(req, handler, context) to listShardAsync(handler, context, req)
  2. The interface LogSystemInterface has an addition of a none default interface method.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chenylee-aws chenylee-aws merged commit 909b890 into awslabs:master Oct 17, 2024
@chenylee-aws chenylee-aws deleted the new_release branch October 17, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants