Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix null pointer exception in getOldestRecordTimeMillis #596

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

jtaub
Copy link
Contributor

@jtaub jtaub commented Oct 5, 2024

Issue #, if available: 489

Description of changes:

  • Refactored getOldestRecordTimeInMillis to avoid a possible NullPointerException which can be caused by a race condition
  • Added a simple unit test for this method

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@chenylee-aws chenylee-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@chenylee-aws chenylee-aws merged commit 0eafc8d into awslabs:master Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants