-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for faster shard reallocation on graceful shutdown #1005
Open
mathieufortin01
wants to merge
4
commits into
awslabs:master
Choose a base branch
from
mathieufortin01:latency-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c5d62f1
Evict lease on shutdown
mathieufortin01 0a28837
Evict lease on shutdown (#1)
mathieufortin01 cc1a641
Merge remote-tracking branch 'upstream/master' into update-2023-08-18
mathieufortin01 946d1f1
Merge branch 'update-2023-08-18' into latency-issue
mathieufortin01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,7 @@ target/ | |
AwsCredentials.properties | ||
.idea | ||
*.iml | ||
.sdkmanrc | ||
.vscode | ||
*.swp | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,6 +227,18 @@ public class LeaseManagementConfig { | |
private long listShardsCacheAllowedAgeInSeconds = 30; | ||
private int cacheMissWarningModulus = 250; | ||
|
||
/** | ||
* Interval at which the lease taker will execute. | ||
* If unspecified, an interval will be calculated based on the lease duration. | ||
*/ | ||
private long leaseTakerIntervalMillis = -1L; | ||
|
||
/** | ||
* If leases should be evicted or not on shutdown requested. | ||
* By default, leases are not evicted. | ||
*/ | ||
private boolean evictLeaseOnShutdown = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New property. If false, same behavior as today which is wait for lease to be expired before taking it. |
||
|
||
private MetricsFactory metricsFactory = new NullMetricsFactory(); | ||
|
||
@Deprecated | ||
|
@@ -329,6 +341,7 @@ public LeaseManagementFactory leaseManagementFactory() { | |
initialPositionInStream(), | ||
failoverTimeMillis(), | ||
epsilonMillis(), | ||
leaseTakerIntervalMillis, | ||
maxLeasesForWorker(), | ||
maxLeasesToStealAtOneTime(), | ||
maxLeaseRenewalThreads(), | ||
|
@@ -364,6 +377,7 @@ public LeaseManagementFactory leaseManagementFactory(final LeaseSerializer lease | |
executorService(), | ||
failoverTimeMillis(), | ||
epsilonMillis(), | ||
leaseTakerIntervalMillis, | ||
maxLeasesForWorker(), | ||
maxLeasesToStealAtOneTime(), | ||
maxLeaseRenewalThreads(), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing this property to clients.