Rust: Update WebAssembly Example #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beqqrry-aws
added
Rust
beqqrry-aws
approved these changes
Jul 27, 2023
beqqrry-aws
added
On Call Review complete
|
Hey @rcoh this PR failed the Rust check. |
|
@rcoh or @beqqrry-aws , do we have any path forward to resolve the failing check on this PR? |
ford-at-aws
force-pushed
the
update-wasm
branch
from
e04f5dc to
a97782e
Compare
|
@jdisanti will look into this. |
|
I think #5286 will resolve the issue here once it is merged. If there continues to be an issue after, I can investigate. |
ford-at-aws
force-pushed
the
update-wasm
branch
from
a97782e to
bc463f3
Compare
beqqrry-aws
force-pushed
the
update-wasm
branch
from
6e41a6c to
404b163
Compare
DavidSouther
approved these changes
Aug 29, 2023
DavidSouther
approved these changes
Aug 29, 2023
scmacdon
force-pushed
the
update-wasm
branch
from
79ac095 to
27e7aea
Compare
Laren-AWS
force-pushed
the
update-wasm
branch
from
27e7aea to
51d1c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the WebAssembly example to take advantage of
TimeSourceoffered by the new version of the AWS Rust SDK & improve logging.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.