-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): add webassembly example #4325
feat(rust): add webassembly example #4325
Conversation
Hey, @eduardomourar, just wanted to let you know I am working on a review for this PR, but I need to do a bit of research on the WebAssembly side of things first! Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again for this! It's a feature that's been in my backlog for an April timeframe, but this definitely jumpstarts that :) Most of the review comments are small nits in the HTML/JS side; the Rust looks really solid. As I mention in a specific comment, this needs a larger User Guide entry, but this is a great start.
This explains how we are making a network "proxy" for wasm using the Fetch API (browser).
Fix closing head tag
I'm adding @lkdavies, our team's editor, for review of the README and prose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
fmt lint
aws-doc-sdk-examples Pull Request
I'm submitting a new SDK code example
The example depends on this PR.
Confirm you have met the following minimum requirements:
Open source license adherence
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.