Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add UpdateReplacePolicy to supported resource attributes. #1986

Closed
wants to merge 1 commit into from

Conversation

sriram-mv
Copy link
Contributor

  • Cloudformation added native support for UpdateReplacePolicy on Jan 2019.

Issue #, if available:

#1807

Description of changes:

  • Addition to supported resource attributes within SAM models.

Description of how you validated changes:

  • Unit tested and validated transformation of template with UpdateReplacePolicy defined.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Cloudformation added native support for UpdateReplacePolicy on Jan
2019.
@codecov-io
Copy link

codecov-io commented Apr 11, 2021

Codecov Report

Merging #1986 (ba0a4b8) into develop (ebaba0c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1986      +/-   ##
===========================================
+ Coverage    93.84%   93.89%   +0.05%     
===========================================
  Files           90       90              
  Lines         5976     5976              
  Branches      1215     1215              
===========================================
+ Hits          5608     5611       +3     
+ Misses         169      167       -2     
+ Partials       199      198       -1     
Impacted Files Coverage Δ
samtranslator/model/__init__.py 98.14% <100.00%> (ø)
samtranslator/translator/logical_id_generator.py 100.00% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaba0c...ba0a4b8. Read the comment docs.

@mndeveci
Copy link
Contributor

mndeveci commented Jun 9, 2021

Closing this since it is been added by 90edf3e

@mndeveci mndeveci closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants