-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release xgboost 1.2 with GPU support #134
Conversation
a85c226
to
6294799
Compare
# Python won’t try to write .pyc or .pyo files on the import of source modules | ||
# Force stdin, stdout and stderr to be totally unbuffered. Good for logging | ||
ENV PYTHONDONTWRITEBYTECODE=1 | ||
ENV PYTHONUNBUFFERED=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this have any impact on performance ? minor maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting point. Those environment variables were kept from previous versions, e.g., https://github.com/aws/sagemaker-xgboost-container/blob/master/docker/1.0-1/base/Dockerfile.cpu#L32, and I didn't think to remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment
Description of changes:
This CR upgrades XGBoost to 1.2 and enables GPU support.
silent
parameter has been removed in 1.1 in favor ofverbose
.survival:aft
is added to support survival analysis: https://xgboost.readthedocs.io/en/latest/tutorials/aft_survival_analysis.html1.0-1-cpu-py3
.nvidia/cuda:${CUDA_VERSION}-base-ubuntu${UBUNTU_VERSION}
is a small image that contains a minimal set of CUDA runtime files.tree_method: gpu_hist
(and use the correct instance type, e.g.,p3.xlarge
,p3.2xlarge
) to enable GPU training.-cpu-py3
in the framework version is also redundant, and this CR proposes to drop the-<architecture>-<python version>
suffix. (However, we will keep the old tag format in the deployment pipelines for backwards compatibility. That is, we will tag the same image with two tags:1.2-1
and1.2-1-cpu-py3
.)Testing: tox, integration tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.