Skip to content

Conversation

@jesterhazy
Copy link
Contributor

Description of changes:

fix RST warnings in the readme file

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • [x ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • [x ] I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy jesterhazy requested a review from nadiaya September 5, 2018 15:22
@codecov-io
Copy link

codecov-io commented Sep 5, 2018

Codecov Report

Merging #381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #381   +/-   ##
======================================
  Coverage    92.9%   92.9%           
======================================
  Files          51      51           
  Lines        3568    3568           
======================================
  Hits         3315    3315           
  Misses        253     253

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9093fb...bfb4b9c. Read the comment docs.

laurenyu
laurenyu previously approved these changes Sep 5, 2018
nadiaya
nadiaya previously approved these changes Sep 5, 2018
README.rst Outdated
3. The AWS account has an IAM role named :code:`SageMakerRole`
4. The libraries listed in the ``extra_require`` object in in ``setup.py`` for ``test`` are installed. You can do this by running the following command:
:code:`pip install --upgrade .[test]`
4. The libraries listed in the ``extras_require`` object in in ``setup.py`` for ``test`` are installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object in in

@jesterhazy jesterhazy dismissed stale reviews from nadiaya and laurenyu via 4591b3a September 5, 2018 16:20
Jonathan Esterhazy added 2 commits September 5, 2018 09:21
@jesterhazy
Copy link
Contributor Author

@nadiaya addressed PR comments

laurenyu
laurenyu previously approved these changes Sep 5, 2018
@jesterhazy jesterhazy merged commit f369661 into aws:master Sep 5, 2018
pdasamzn pushed a commit to pdasamzn/sagemaker-python-sdk that referenced this pull request Nov 1, 2018
* fix rst warnings

* fix typo

* fix image link

* update version to 1.9.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants