Add support for PyTorch #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it's not yet supported.
Fix whitespaces. Make python3 to be default for pytorch estimator.
Add Pytorch estimator and model
…sion based on the current environment python version.
Add integ tests for pytorch prediction.
Add support for pytorch 0.4.0. Make 0.4 to be default version. Get rid of 03.1 support.
* Switch pytorch estimator integ tests to use script mode. Replace double quotes with single quotes. * Switch failure script to use script mode.
* Add initial Readme commit for PyTorch. * Update table of contents. Readme updates. * Add more info about distributed training. * PR comments. * Add notes about argparse actions and how to use boolean hyperparameters.
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 92.18% 92.29% +0.11%
==========================================
Files 45 49 +4
Lines 3197 3257 +60
==========================================
+ Hits 2947 3006 +59
- Misses 250 251 +1
Continue to review full report at Codecov.
|
owen-t
reviewed
Jun 20, 2018
| Your PyTorch training script must be a Python 2.7 or 3.5 compatible source file. | ||
|
|
||
| The training script is very similar to a training script you might run outside of SageMaker, but you | ||
| can access useful properties about the training environment through various environment variables, such as |
Contributor
There was a problem hiding this comment.
Saying "such as" kind of makes me think there is a complete list somewhere of all of these variables, but I can't find it. How does a customer get a list of all the environment variables?
Contributor
Author
There was a problem hiding this comment.
It's bellow:
For more on training environment variables, please visit SageMaker Containers <https://github.com/aws/sagemaker-containers>_.
owen-t
approved these changes
Jun 20, 2018
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Nov 26, 2019
* Rename ScriptModeProcessor to ScriptProcessor * Move arguments param down to run method in Processor classes * Remove py_version from ScriptProcessor and add command as a param to ScriptProcessor.run * Remove Enums in favor of string literals
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Dec 4, 2019
* Rename ScriptModeProcessor to ScriptProcessor * Move arguments param down to run method in Processor classes * Remove py_version from ScriptProcessor and add command as a param to ScriptProcessor.run * Remove Enums in favor of string literals
knakad
pushed a commit
that referenced
this pull request
Dec 4, 2019
* Rename ScriptModeProcessor to ScriptProcessor * Move arguments param down to run method in Processor classes * Remove py_version from ScriptProcessor and add command as a param to ScriptProcessor.run * Remove Enums in favor of string literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #53
Add support for PyTorch framework.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.