Skip to content

Conversation

@nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Jun 15, 2018

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested a review from yangaws June 15, 2018 04:16
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files          45       45           
  Lines        3166     3166           
=======================================
  Hits         2896     2896           
  Misses        270      270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb91511...d49192e. Read the comment docs.

yangaws
yangaws previously approved these changes Jun 15, 2018
Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would be better if the equal signs under 1.4.2 in change log get aligned with 1.4.2 in length.

Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@nadiaya nadiaya merged commit 2e2e397 into aws:master Jun 15, 2018
@nadiaya nadiaya deleted the 1.4.2 branch June 28, 2018 00:17
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
Updating one line in the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants