Skip to content

breaking: remove estimator parameters for TF legacy mode #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2020
Merged

breaking: remove estimator parameters for TF legacy mode #1510

merged 3 commits into from
May 27, 2020

Conversation

@laurenyu
Copy link
Contributor

@laurenyu laurenyu commented May 19, 2020

Issue #, if available:
#1462

Description of changes:
This change removes a lot of the "training helpers" associated with TF legacy mode, such as:

  • the option to automatically run TensorBoard locally
  • the parameters training_steps, evaluation_steps, checkpoint_path, and requirements_file, which currently are simply translated into hyperparameters

still left:

  • remove the old serving stuff
  • perhaps take a more aggressive stance on deprecating legacy mode by forcing any framework_version < 1.11 to specify the image URI directly
  • redo all the unit tests
    • related to this - there are a bunch of outdated framework version fixtures (not just for TF) with a TODO comment about getting rid of them

Testing done:
tox --parallel all tests/unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to any/all clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

sagemaker-bot commented May 19, 2020

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ajaykarpur ajaykarpur self-requested a review May 27, 2020 17:50
ajaykarpur
ajaykarpur reviewed May 27, 2020
View reviewed changes
src/sagemaker/tensorflow/estimator.py
"""Handle end-to-end training and deployment of user-provided TensorFlow code."""

__framework_name__ = "tensorflow"
_SCRIPT_MODE_REPO_NAME = "tensorflow-scriptmode"
Copy link
Contributor

@ajaykarpur ajaykarpur May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this repo name used by the DLC images?

Copy link
Contributor Author

@laurenyu laurenyu May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's used only by the TF 1.11-1.13 images. this PR still preserves the image URI stuff for older images, though arguably it could be removed as well. definitely open to it.

Copy link
Contributor

@ajaykarpur ajaykarpur May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think it's probably safe to remove that functionality for older images and require users to specify the image URI directly, but I'm also fine with leaving it as is.

Copy link
Contributor Author

@laurenyu laurenyu May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably do it in a separate PR then, and add some appropriate warnings. maybe once #1464 is finished, it'll be cleaner.

ajaykarpur
ajaykarpur reviewed May 27, 2020
View reviewed changes
ajaykarpur
ajaykarpur reviewed May 27, 2020
View reviewed changes
@laurenyu laurenyu merged commit 40f1d75 into aws:zwei May 27, 2020
@laurenyu laurenyu deleted the tf-remove-legacy-mode branch May 27, 2020 19:04
This was referenced May 29, 2020
Merged
Merged
Merged
sage-maker pushed a commit that referenced this pull request Aug 7, 2024
@mohamedzeidan2021
feat: implemented security-monitoring to send metrics to CW #1510 (#4821
932c184 
)

* added security-monitoring

* changed role name

* all metrics under same namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ajaykarpur ajaykarpur ajaykarpur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laurenyu @sagemaker-bot @ajaykarpur