-
Notifications
You must be signed in to change notification settings - Fork 80
feat: support codeartifact for installing requirements.txt packages #130
Conversation
|
I've been using the codeartifact-related code for a few months already. I was not able to add any related integration tests as such tests would require access to a fixed codeartifact repo, and for the container to have access to AWS credentials. I'm asking for guidance if any such integ tests would be needed here. Additionally, is anything required in README to mention this CodeArtifact support? |
|
I did some testing by modifying where I then went ahead and started the container - once without setting the Without (i.e. public pypi index) With (i.e. from CodeArtifact index) |
|
I think it makes more sense to add a new feature which allow user to run plugin module at model server start time than add more specialized function here. |
506fce7 to
b0ca7e3
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
- add a dependency on boto3 for calling codeartifact apis - update model_server to check for the presence of codeartifact (CA_* prefixed) environment variable - if env variable is present, build the authenticated endpoint index url, and add that to the pip install command, otherwise keep using pypi index closes aws#85
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available: #85
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.