Bug fixes for cluster creation and pytorch job #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for efa for pytorch job, remove default request and limits when instance type is none
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
approved these changes
Nov 20, 2025
| from the template registry or remote source. | ||
| """ | ||
| # Placeholder implementation - currently returns 1 as the latest version | ||
| return 1 |
Collaborator
There was a problem hiding this comment.
Is 1 the latest version? I think you're right, but just confirming if that's how Pintao set up cluster versioning I don't remember.
Collaborator
Author
There was a problem hiding this comment.
This task needs follow up when Pintao is back. Currently only 1 is supported as the latest version.
Collaborator
Author
There was a problem hiding this comment.
#285 This is the previous PR for template versioning.
mohamedzeidan2021
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
template-versionflag to optional for cluster create, also implemented a placeholder function to get the latest cluster template version. Would need a thorough implementation on this for follow-up.node_count> 1,vpc.amazonaws.com/efa: 1will be added to resource requests and limitsBefore/After UX
Before:
After:
How was this change tested?
Are unit tests added?
Are integration tests added?
Reviewer Guidelines
One of the following must be true: