Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/cli/cluster_management/cli_cluster_management.md
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ The `config.yaml` file supports the following parameters:
| `create_s3_endpoint_stack` | BOOLEAN | Create S3 Endpoint stack | true |
| `enable_hp_inference_feature` | BOOLEAN | Enable inference operator | false |
| `stage` | TEXT | Deployment stage ("gamma" or "prod") | "prod" |
| `custom_bucket_name` | TEXT | S3 bucket name for templates | "sagemaker-hyperpod-cluster-stack-bucket" |
| `custom_bucket_name` | TEXT | S3 bucket name for templates | "aws-sagemaker-hyperpod-cluster" |
| `create_life_cycle_script_stack` | BOOLEAN | Create Life Cycle Script Stack | true |
| `create_s3_bucket_stack` | BOOLEAN | Create S3 Bucket Stack | true |
| `s3_bucket_name` | TEXT | S3 bucket for cluster lifecycle scripts | "s3-bucket" |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ClusterStackBase(BaseModel):
create_s3_endpoint_stack: Optional[bool] = Field(True, description="Boolean to Create S3 Endpoint stack")
enable_hp_inference_feature: Optional[bool] = Field(False, description="Boolean to enable inference operator in Hyperpod cluster")
stage: Optional[str] = Field("prod", description="Deployment stage used in S3 bucket naming for inference operator. Valid values: \"gamma\", \"prod\"")
custom_bucket_name: str = Field("sagemaker-hyperpod-cluster-stack-bucket", description="S3 bucket name for templates")
custom_bucket_name: str = Field("aws-sagemaker-hyperpod-cluster", description="S3 bucket name for templates")
create_life_cycle_script_stack: Optional[bool] = Field(True, description="Boolean to Create Life Cycle Script Stack")
create_s3_bucket_stack: Optional[bool] = Field(True, description="Boolean to Create S3 Bucket Stack")
s3_bucket_name: Optional[str] = Field("s3-bucket", description="The name of the S3 bucket used to store the cluster lifecycle scripts")
Expand All @@ -51,6 +51,7 @@ class ClusterStackBase(BaseModel):
file_system_type_version: Optional[float] = Field(2.15, description="File system type version for the FSx file system")
storage_capacity: Optional[int] = Field(1200, description="Storage capacity for the FSx file system in GiB")
fsx_file_system_id: Optional[str] = Field("", description="Existing FSx file system ID")
template_version: str = Field("1", description="Version number of cluster creation template")

@field_validator('kubernetes_version', mode='before')
@classmethod
Expand Down Expand Up @@ -120,7 +121,7 @@ def to_config(self, region: str = None):

# Set fixed defaults
defaults = {
'custom_bucket_name': 'sagemaker-hyperpod-cluster-stack-bucket',
'custom_bucket_name': 'aws-sagemaker-hyperpod-cluster',
'github_raw_url': 'https://raw.githubusercontent.com/aws-samples/awsome-distributed-training/refs/heads/main/1.architectures/7.sagemaker-hyperpod-eks/LifecycleScripts/base-config/on_create.sh',
'helm_repo_url': 'https://github.com/aws/sagemaker-hyperpod-cli.git',
'helm_repo_path': 'helm_chart/HyperPodHelmChart'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@
"title": "Stage"
},
"custom_bucket_name": {
"default": "sagemaker-hyperpod-cluster-stack-bucket",
"default": "aws-sagemaker-hyperpod-cluster",
"description": "S3 bucket name for templates",
"title": "Custom Bucket Name",
"type": "string"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ def create(self,
stack_name = f"HyperpodClusterStack-{str(uuid.uuid4())[:5]}"
# Use the fixed bucket name from the model
bucket_name = self.custom_bucket_name
template_key = f"1.1/main-stack-eks-based-template.yaml"
template_key = f"{self.template_version}/main-stack-eks-based-template.yaml"

try:
# Use TemplateURL for large templates (>51KB)
template_url = f"https://{bucket_name}.s3.amazonaws.com/{template_key}"
template_url = f"https://{bucket_name}-{region}-{self.stage}.s3.amazonaws.com/{template_key}"
response = cf.create_stack(
StackName=stack_name,
TemplateURL=template_url,
Expand Down
Loading