revert node-count val #253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
the pytorch job expects 1 of the following 2 (not both)
node-countcombination of accelerators, vcpu, memory-in-gib must be specified for instance-type ml.p4d.24xlargethis change reverts the default of node_count back to None, so users can specify on the pytorch job flags whether they want one or the other.
How was this change tested?
tested locally by running commands like
Unit test coverage
Do we need integration tests?
Checklist