Add forbid extra for pydantic BaseModel #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
benieric
force-pushed
the
extra-forbid
branch
2 times, most recently
from
ac24a39 to
984b78a
Compare
benieric
changed the title
benieric
force-pushed
the
extra-forbid
branch
2 times, most recently
from
b9d2ad3 to
9263813
Compare
benieric
changed the title
pintaoz-aws
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #154
Description of changes:
Add
extra="forbid"to ConfigDict used in pydantic BaseModelRan
python src/sagemaker_core/tools/codegen.pysince change was made in template. Other changes are from formattingFiles to look at with relevant changes. Others were from
python src/sagemaker_core/tools/codegen.pymaking formatting changes:src/sagemaker_core/main/resources.py- addextra="forbid"src/sagemaker_core/main/shapes.py- addextra="forbid"src/sagemaker_core/main/utils.py- filter fields not in the class when creating object in ResourceIteratorsrc/sagemaker_core/tools/templates.pyDo not merge - I think there is some discrepency with black where it is not consistent across environments
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.