ci: add timeout for cbmc proof #5038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
approved these changes
Jan 15, 2025
jouho
approved these changes
Jan 15, 2025
johubertj
pushed a commit
to johubertj/s2n-tls
that referenced
this pull request
Feb 13, 2025
Co-authored-by: Boquan Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Description of changes:
We noticed that Run CBMC Proofs Workflow sometimes hang for six hours and then Github terminates the workflow. Here is an example. We want to lower the timeout limit to 60 minutes. Run CBMC Proofs Workflow typically only takes 30 minutes to finish. To set the timeout, refer to the Github Action Page.
For this CBMC workflow hanging, we suspect the problem happens in:
s2n-tls/.github/workflows/proof_ci.yaml
Lines 120 to 121 in 6cc9f53
Call-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.